refactor: establish WebAudio folder feature - #329
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d44e1a7b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-web-audio-folder
branch
from
August 4, 2026 17:31
0d44e1a to
2bdc163
Compare
jderochervlk
force-pushed
the
codex/option5-web-audio-folder
branch
2 times, most recently
from
August 5, 2026 12:31
1de339d to
827f126
Compare
jderochervlk
force-pushed
the
codex/option5-web-audio-folder
branch
2 times, most recently
from
August 5, 2026 13:40
0e61014 to
6631cc1
Compare
jderochervlk
force-pushed
the
codex/option5-web-audio-folder
branch
3 times, most recently
from
August 5, 2026 14:30
d291f81 to
806cf99
Compare
jderochervlk
force-pushed
the
codex/option5-web-audio-folder
branch
from
August 5, 2026 14:50
806cf99 to
490d3c1
Compare
jderochervlk
force-pushed
the
codex/option5-web-audio-folder
branch
2 times, most recently
from
August 5, 2026 15:45
066c385 to
b96e7b3
Compare
jderochervlk
force-pushed
the
codex/option5-web-audio-folder
branch
from
August 5, 2026 17:40
b96e7b3 to
3c685fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 19 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #328.
Summary
src/WebAudioto the targetsrc/web-audiofolderWebAudiofeatureWebAPI.WebAudio -> WebAPI.Media + WebAPI.Messaging + WebAudiofeatureDependency note
The Option 5 proposal listed only Media as a public dependency. The current bindings also expose
MessagePortfromAudioWorkletNode.port, so the compiler-proven closure additionally requiresWebAPI.Messaging. This PR records the real public signature dependency at the domain level.Temporary state
WebAPI.DOMsource entry remains until its remaining interfaces have been assignedReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTML,Media,Messaging,WebAudionpm run buildnpm testnpm run format:checkgit diff --check